https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7806
Evan Huus <eapache@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eapache@xxxxxxxxx
--- Comment #2 from Evan Huus <eapache@xxxxxxxxx> 2012-10-07 06:39:38 PDT ---
Hi Tomofumi, thanks for the patch. Two quick questions:
- Why do you register hf_mpls_echo_tlv_fec_rsvp_p2mp_ipv4_ext_tunnel_id as a
uint32 and then add it to the tree with proto_tree_add_text as an IPv4 address?
Wouldn't it be easier to just register it as an IPv4 field?
- There are a few places where you use proto_tree_add_text to display an error
condition - is there a particular reason you're not using
expert_add_info_format?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
