Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 7598] Multi-threaded statistics calculation (cf_retap_pack

Date: Fri, 31 Aug 2012 08:30:49 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7598

--- Comment #6 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-08-31 08:30:49 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Created attachment 8918 [details]
> > > Move global tap data to packet_info structure
> > > Currently statistics are using global variables inside tap.c, move them to
> > > packet_info structure.
> > 
> > Should this patch be applied? It looks OK to me.
> We need it only if we want to start working on multithread libwireshark. Not
> sure if we want it in 1.10 (killer feature for 1.10? :>).
> If someone is concerned about much bigger size of packet_info structure,
> I have also another version which uses list instead of array.

I was thinking that geting rid of global variables is a good thing regardless.

I've been thinking that packet_info should perhaps work similar to per packet
info to only hold info relevant to the frame in question or atleast put
some info in "sub structs" that can be NULL.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.