https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7654
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mmann78@xxxxxxxxxxxx
--- Comment #4 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-08-20 06:43:22 PDT ---
(In reply to comment #3)
> Hi Lorand,
> a few comments regarding your patch:
> - in line 1302
> proto_tree_add_item(lisp_tree, hf_lisp_xtrid, tvb, offset, LISP_XTRID_LEN,
> ENC_BIG_ENDIAN);
> should be replaced by
> proto_tree_add_item(lisp_tree, hf_lisp_xtrid, tvb, offset, LISP_XTRID_LEN,
> ENC_BIG_ENDIAN);
> as hf_lisp_xtrid is FT_BYTES
I believe you meant change to:
proto_tree_add_item(lisp_tree, hf_lisp_xtrid, tvb, offset, LISP_XTRID_LEN,
ENC_NA);
I would also like to see some of the "error messages" placed in
proto_tree_add_text to be replaced with expert_add_info_format
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
