Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 7514] ISDN LAPD X.31 packet traffic can not be decoded

Date: Mon, 23 Jul 2012 01:04:11 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7514

--- Comment #4 from Karsten Keil <isdn@xxxxxxxxxxxxxx> 2012-07-23 01:04:10 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > +    x31_handle = find_dissector("x.25");
> > 
> > If you really need another handle, please add some comment. 
> > On first sight, it looks like typo.
> > 
> > Or just use x25_handle:
> > +    dissector_add_uint("lapd.sapi", LAPD_SAPI_X25, x25_handle);
> 
> I'm assuming the intent is to have an X.31 dissector that shares most of the
> code with the X.25 PLP dissector but labels it as X.31 in the Protocol column
> instead, as per

Yes, exactly, for the quick fix without X.31 display, reusing the
x25_handle would be enough I agree.

> 
> > Only cosmetic issue is, that the protocol is still displayed as X.25 in the
> > protocol column - maybe somebody who knows more about the internals of
> > wireshark can register X.31 as second protocol type for X.25 and use it for
> > LAPD SAPI 16 traffic.
> 

I tried it, to add a protocol similar to the X.25 code, but still using all the
X.25 functions, but in the end I got some warnings about double registered
structs and it did not work.
If somebody could point me to some documentation or to a protocool, which does
something like this, I could try it again.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.