https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7514
--- Comment #3 from Guy Harris <guy@xxxxxxxxxxxx> 2012-07-22 15:48:59 PDT ---
(In reply to comment #2)
> + x31_handle = find_dissector("x.25");
>
> If you really need another handle, please add some comment.
> On first sight, it looks like typo.
>
> Or just use x25_handle:
> + dissector_add_uint("lapd.sapi", LAPD_SAPI_X25, x25_handle);
I'm assuming the intent is to have an X.31 dissector that shares most of the
code with the X.25 PLP dissector but labels it as X.31 in the Protocol column
instead, as per
> Only cosmetic issue is, that the protocol is still displayed as X.25 in the
> protocol column - maybe somebody who knows more about the internals of
> wireshark can register X.31 as second protocol type for X.25 and use it for
> LAPD SAPI 16 traffic.
in comment #1.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
