https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493
--- Comment #5 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-07-22 03:14:58 PDT ---
Hi,
some more comments
Variables should be declared at the beginning of a function, not inside an
if-else block etc. See doc/README.developer, section 1.1.1
Why do all hf variables use the type FT_STRING? I suggest that you use numeric
types like FT_UINT8, ... for fields that represent a numeric value, e.g.
sequence number. You can find lots of examples for this in other dissectors.
Regards,
Martin
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
