https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7428
--- Comment #12 from Richard Sharpe <realrichardsharpe@xxxxxxxxx> 2012-07-04 12:58:21 PDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > Created attachment 8716 [details]
> > Heh, probably the last version for a while.
> >
> > Fixed the problems found by checkhf.pl.
> >
> > I don't have a capture with extension in it so I didn't find it before ...
>
> Sorry there is a small issue I missed during last review. FT_GUID should use a
> ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN encoding argument and not a ENC_NA.
> ENC_BIG_ENDIAN would behave the same way as your current ENC_NA but I'm a bit
> surprised as everything else is coded in little endian. Could you confirm which
> value is the right one?
> I also locally changed hf_negoex_extension_vector_pad from FT_UINT32 to
> FT_BYTES to match the other *_pad entries and the ENC_NA argument.
>
> Thanks,
> Pascal.
The spec says:
"NegoEx does not use ASN.1 encoding and it uses simple C structures
encoded in little endian for all its messages."
So, it should be ENC_LITTLE_ENDIAN, I believe.
Thanks.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
