Wireshark-bugs: [Wireshark-bugs] [Bug 2402] Data string filter crash
Date: Sun, 24 Jun 2012 02:39:39 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

--- Comment #13 from Jakub Zawadzki <[email protected]> 2012-06-24 02:39:38 PDT ---
(In reply to comment #12)
> Updated list for r43451.

Just a note: Using the same name for FT_FLOAT and FT_DOUBLE types is 100% safe.
(i.e.:
  tds.type_varbyte.data.double, tds.type_varbyte.data.float
  pcp.instance.value.float, pcp.instance.value.double
)

(Right now I don't have access to my SSH key so I can't commit it).


But maybe instead of renaming all fields, and later changing it back when we
implement converting values.
Just check if cmp_* function are the same for both types.

Like:

gboolean
fvalue_eq(fvalue_t *a, fvalue_t *b)
{
        g_assert(a->ftype->cmp_eq);
        if (a->ftype->cmp_eq == b->ftype->cmp_eq)
           return a->ftype->cmp_eq(a, b);
        return FALSE;
}

We'll avoid crash this way..., but we must notify user about possible wrong
results of such filter.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.