Wireshark-bugs: [Wireshark-bugs] [Bug 6682] Add support for color xml attributes in psml and pdm
Date: Wed, 20 Jun 2012 19:14:24 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6682

--- Comment #11 from Chris Maynard <[email protected]> 2012-06-20 19:14:24 PDT ---
(In reply to comment #10)
> Created attachment 8632 [details]
> Add color attributes to pdml, psml, and normal output

The synopsis lists the new types for the -T option, but the summary line for
the -T option doesn't.

Compiling on Windows failed as follows:
color_filters.c
c:\wireshark\work\color_filters.c(720) : error C2220: warning treated as error
- no 'object' file generated
c:\wireshark\work\color_filters.c(720) : warning C4700: uninitialized local
variable 'path' used

I changed path to pf_dir_path and it compiled OK, but I'm not seeing any
coloring affects with normal output on Windows 7 64 in either the command
prompt, cygwin or powershell.  I guess I must be missing something.

I also tested the cpdml output and that looks pretty good :) ... although - and
these things have nothing to do with this bug - I think the cpdml/pdml
output/performance could be improved, such as:

    1) if you hide a node ... how do you unhide it ... w/out reloading the
file, of course?
    2) large (~600MB) pdml files seized up both my IE & Firefox browsers and
each one had to be killed, IE by the task manager & Firefox by "Close Program"
due to not responding (IDK, maybe it was still slowly chugging along and I was
just too impatient).

Regarding:
> Enable color filter processing in TShark if any -e or -R options contain
> "frame.coloring_rule.". We may want to be less clever about this and just
> enable it when verbose output is enabled but it seemed better than adding yet
> another option or flag.

When I first read that, I thought you HAD to include a -R
"frame.coloring_rule.*" even if using "-T cpdml", which I thought was odd, but
after testing it, I now see that it's only if you use "-T pdml".  So now I'm
wondering if the output should only be colorized when using the colorized
output format and never colorized with "-T pdml"?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.