https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7300
--- Comment #3 from Stephen Donnelly <stephen@xxxxxxxxxx> 2012-06-20 16:26:03 PDT ---
(In reply to comment #2)
> I'd prefer to have main part of this code in libpcap.
> - interface_id in pcap_pkthdr.
You mean create a custom sf_pkthdr with new magic number, savefile support etc?
I assume that struct pcap_pkthdr can't be changed without breaking
compatibility.
> If not possible, well:
>
> 1/ use some define instead of 197...
I noticed that get_pcap_linktype() in dumpcap.c has a lot of code like "if
(linktype == 7)", so I was assuming that using bpf.h DLT_* defines was frowned
upon.
I didn't want to use wtap_wtap_encap_to_pcap_encap() or vice versa in
capture_loop_write_packet_cb() as those calls perform linear searches.
Any suggestions on where I could cache the mapping?
> 2/ g_malloc() can't fail
Will fix.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
