Wireshark-bugs: [Wireshark-bugs] [Bug 6682] Add support for color xml attributes in psml and pdm
Date: Wed, 20 Jun 2012 11:43:44 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6682

Jakub Zawadzki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Jakub Zawadzki <[email protected]> 2012-06-20 11:43:44 PDT ---
Hi,

(In reply to comment #1)
> Created attachment 7588 [details]
> Patch to add color attributes to psml and pdml outputs.

1/ Do you really need 'color_filter_default'?
   When packet don't match any colorize filters I'd prefer to remain it NULL.
   and later any application can use their own defaults.

2/ #ifndef _tshark_ is wrong, when possible please split color_filters.c
 into two or three files, used commonly by wireshark and tshark, used by only
wireshark, and used only by tshark.


3/ Conversion from 16-bits color to 8-bit for html output.

   I'd rather not convert it when initializing but when writting XML, smth
like:
static const char *
color_to_html(color_t *c)
{
  return ep_strdup_printf("#%02x%02x%02x", 
             c->red >> 8, c->green >> 8, c->blue >> 8);
}

(not tested)

Still thanks for patch :)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.