Wireshark-bugs: [Wireshark-bugs] [Bug 6844] Universal Alcatel Protocol - Reloaded
Date: Sat, 9 Jun 2012 06:07:09 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

--- Comment #28 from Bill Meier <[email protected]> 2012-06-09 06:07:08 PDT ---
(In reply to comment #26)

Not having received a response to comment #26, I've done as indicated below
(inline).

Please advise as to item #1 as well as whether actions taken for items 2 & 3 
are correct.

Thanks

> Some questions based on working on packet-ua3g.c
> 
> 1. There are a number of cases with code as follows:
> 
>    for (i = 1; i <= parameter_length; i++) {
>        if (isprint(tvb_get_guint8(tvb, offset + 1 + i)))
>            ep_strbuf_append(strbuf, tvb_get_const_stringz(tvb, offset+1+i,
> NULL));
>        else
>            ep_strbuf_append(strbuf, tvb_get_const_stringz(tvb, offset+1+i,
> NULL));
>                             }
> 
>    a. The strings stored are the same for both branches
>    b. The 'stringz' strings are generated starting at offsets 1,2,3,4,5,...
> 
>    Neither of the above seem right. If not, what is the correct code ?
> 

Left unchanged with XXX comment


> 2. In decode_lcd_line_cmd() the string stored in strbuf is never used
>    and no value is stored in str_ascii before use.
> 
>    Is str_ascii supposed to be generated from the strbuf or something ?
> 

strbuf->str was used in place of str_ascii (commenting out the use of
str_ascii).


> 3. In decode_dwl_special_char(), the strings stored in strbuf are never 
>    actually used.
> 
>    /* The following loop will draw a picture of the character with "spaces" and
> "o" */

Used strbuf->str instead of byte_char in the proto_tree_add_text() statement.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.