https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
Bill Meier <wmeier@xxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #12 from Bill Meier <wmeier@xxxxxxxxxxx> 2012-06-06 19:10:14 PDT ---
I've re-opened this bug for 2 reasons:
1. I'm working on fixing some issues such as;
- calling col_...() functions under 'if (tree)'
- unneeded check_col() usage;
- use col_set_str() instead of col_add_fstr()
- mismatch between proto_tree_add_item() size arg and the FT type in the
referenced hf[] entry (in a few cases)
- FT_STRING fields should have ENC_ASCII|ENC_NA as the 'encoding' arg
in the corresponding proto_tree_add_item() call.
- ...
2. The following seems incorrect
gint WrethNackPacket(tvbuff_t *tvb, guint8 Offset, packet_info * pInfo,
proto_tree * pWrethTree)
{
guint16 Size;
guint16 ErrorCode;
Size = tvb_get_letohs(tvb,2);
ErrorCode = tvb_get_letohs(tvb,2); <=== what should the offset be ??
I'll close this bug again once I've completed the changes....
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
