Wireshark-bugs: [Wireshark-bugs] [Bug 3315] Segments of reassembled PDU's not saved when saving
Date: Mon, 4 Jun 2012 12:15:15 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #26 from [email protected] 2012-06-04 12:15:14 PDT ---
(In reply to comment #20)
> Turns out this wasn't quite as complicated as I had thought; I fixed it in
> r41216.  You can read the rather long checkin comment here:
> 
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=41216
> 
> It hasn't been tested on Windows yet (Windows uses a different Save-As dialog
> than other platforms).
> 
> It seems to work well for me with reassembled SCTP and TCP packets. 
> Reassembled IP packets "should" work but I didn't have any sample captures
> using IP fragmentation handy.
> 
> If you're interested (and it actually compiles ;-)), you can try it out after a
> few hours with one of the buildbot builds:
> 
> http://www.wireshark.org/download/automated/
> 
> Any feedback is welcome.

Thanks for this long-awaited fix! I confirm it works perfectly for reassembled
IP packets (tested with fragmented SIP packets in UDP) when saving with a
display filter.

But it still does not work when saving "marked" packets when some are
reassembled. So I propose the following improvement:
When marking a reassembled packet, it will automatically mark the corresponding
fragmented packets too. So when saving with "marked" packets, everything will
be saved.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.