Wireshark-bugs: [Wireshark-bugs] [Bug 7324] Add support for the Gluster Handshake and Callback R
Date: Sun, 3 Jun 2012 09:49:52 -0700 (PDT)

--- Comment #2 from Niels de Vos <[email protected]> 2012-06-03 09:49:51 PDT ---
(In reply to comment #1)
> as those protocols seem related to GlusterFS, shouldn't the file be named
> packet-glusterfs_hndsk.c and the protocols named glusterfs.hndsk and
> glusterfs.cbk (to be consistent with the existing packet-glusterfs.c
> dissector)?

It's something that I considered. Personally I do not have a strong preference
for the current implementation or your suggestion. The upstream glusterfs
sources mix "gluster" and "glusterfs" all the time :-/ For example, the
Callback protocol is referred to "Gluster Callback" server-side, but "GlusterFS
Callback" client-side. I don't remember anymore why I chose to use "Gluster"
sometimes and "GlusterFS" for other RPC-protocols.

I don't object to rename the files, protocols and all filters to "glusterfs" so
that all it more consistent in wireshark itself. Please let me know if you want
me to file patches for this.


Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.