Wireshark-bugs: [Wireshark-bugs] [Bug 7310] Initial support for the GlusterFS RPC-protocol
Date: Fri, 1 Jun 2012 08:50:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7310

--- Comment #7 from Niels de Vos <[email protected]> 2012-06-01 08:50:02 PDT ---
(In reply to comment #6)
> please fill separate bugs. Note sure we will meet the deadline though (the time
> remaining is really short)...

Yeah, I understand. I was not planning on getting everything included already,
so don't worry if we can't make it.

> According to README.developer, a FT_BOOLEAN type with an empty bitmask should
> use BASE_NONE:
>     { &hf_glusterfs_flags_rdonly,
>         { "O_RDONLY", "glusterfs.flags.rdonly", FT_BOOLEAN, BASE_NONE,
>             TFS(&tfs_set_notset), 00000000, NULL, HFILL }
>     },

I've tried this, but when I update the code but adding the
hf_glusterfs_flags_rdonly to the flag_bits in glusterfs_rpc_dissect_flags() and
removing the rdonly_item and rdonly_tree parts, I hit an assertion error:

proto.c:7187: failed assertion "hf->bitmask != 0"

When using value 32 instead of BASE_NONE and the explicit rdonly_item,
rdonly_tree in glusterfs_rpc_dissect_flags() all looks good at least. I'm not
sure what how it's supposed to work with BASE_NONE :-/

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.