Wireshark-bugs: [Wireshark-bugs] [Bug 6955] H323 IDs have the domain truncated after '@' in H225
Date: Sat, 31 Mar 2012 13:33:55 -0700 (PDT)

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
   Attachment #8119|                            |review_for_checkin?
              Flags|                            |

--- Comment #2 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-03-31 13:33:54 PDT ---
Created attachment 8119
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8119
per: pass number of bytes to convert not count of UCS-2 characters

(In reply to comment #1)
> For wath it's worth; the bug was introduced in
> http://anonsvn.wireshark.org/viewvc?view=revision&revision=39530
> Replace use of tvb_get_ephemeral_faked_unicode() by use of
> tvb_get_ephemeral_unicode_string();

In tvb_get_ephemeral_faked_unicode() length is used as number of UTF-16
In tvb_get_ephemeral_unicode_string() length is used as number of bytes...

Heh, it's off-by-one shift ;/

i.e. if we had:
      transport_info = tvb_get_ephemeral_faked_unicode(tvb, offset,
(length_remaining - 20)/2, TRUE);

it should be:
     transport_info = tvb_get_ephemeral_unicode_string(tvb, offset,
length_remaining - 20, ENC_LITTLE_ENDIAN);

so on... Attaching P0F fix for h225 (it's called from packet-per.c)

We *really* need some automatic regression testing...

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.