https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #1 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2012-02-29 19:16:10 PST ---
A very quick look through the code says it looks good. But:
- the checkAPIs script reports some minor problems
- the checkhf script reports some unused hf_ entries (minor, but does that
point out bugs or just future work?) and that hf_aem_sf_subtype isn't
registered (major - would cause an abort)
- proto_tree_add_item()'s last argument should no longer be TRUE/FALSE but
ENC_*. tools/fix-encoding-args.pl will help fix that for you.
- This code isn't really necessary:
+ switch (subtype)
+ {
+ case 0x7A:
+ {
+ if (dissector_try_port(avb_dissector_table, 0x7A, tvb, pinfo,
tree))
You can just call dissector_try_port(..., subtype, ...): if no dissector is
registered for the subtype, it just won't be called.
- What's up with this at the end of several functions?
+ pinfo = NULL;
+}
Also important: can you attach a sample capture for testing? (Speaking of
which, has this dissector been fuzz tested (tools/fuzz-test.sh)?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
