https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6786
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2012-02-03 14:14:56 PST ---
Odd, there were *some* (but not all) lines in the patch with ^M's (DOS line
endings) in them. Anyway, I managed to apply the patch.
I did note that checkhf finds some issues with the dissector; can these hf's be
removed?
Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_segment_size
Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_data
Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_sacmd_reserved
Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_sano
Unused entry: epan/dissectors/packet-opensafety.c, hf_oss_ssdo_inhibit_time
Lastly, where are there some sample captures of this protocol? The bugs listed
in the dissector's history don't have any (except for one fuzz failure) and
neither does the wiki's SampleCaptures page. Could you add some to a bug
(maybe this bug) both for our regression testing and automatic fuzz testing?
Anyway, thanks for the contribution!
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
