https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6686
--- Comment #8 from Jelmer Vernooij <jelmer@xxxxxxxxx> 2011-12-20 13:35:20 PST ---
Hi,
Thanks for reviewing.
(In reply to comment #3)
> I've started reviewing the code (not finished), and have a few comments so far:
>
> - The includes stdio.h and stdlib.h shouldn't be necessary
>
> - In dissect_prefixed_bencode(), plen is defined as a guint16 (16-bit unsigned
> integer) but it is assigned using tvb_get_ntohl() which is for what was
> traditionally known as a long (unsigned 32-bit integer in this case). This
> could lead to an overflow if the number is very large -- should plen be changed
> to a guint32 or should the function be changed to tvb_get_ntohs() (for a 16-bit
> short). The same goes for plen in dissect_prefixed_bytes()
Whoops, I'll have a look at fixing those.
Cheers,
Jelmer
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
