https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
Ankith <ankitha@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7520|review_for_checkin? |
Flag| |
Attachment #7520|0 |1
is obsolete| |
Attachment #7525| |review_for_checkin?
Flag| |
--- Comment #15 from Ankith <ankitha@xxxxxxx> 2011-12-05 03:34:07 PST ---
Created an attachment (id=7525)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7525)
Made changes to the patch according to the comments
Thank you for your quick review, the following changes are done-
-->Never ever wrap col_* functions in 'if (tree)' conditions.
-removed col_* func out of 'if' condition
-->Your dissect_* functions should all be static.
-all the functions are made static
-->Use consistent indentation, spaces are preferred.
-expanded all the tabs to spaces.
-->No C++ style comments allowed for portability reasons.
-removed the comment.
-->Have a look at proto_tree_add_boolean_bits_* for bitfield dissection.
-unable to find the function in docs, also can you tell me where I have
to replace the function with the suggested function?
-->dissect_link_param_rpt always shows BELOW THRESHOLD
-changed it to work properly
-->You could use more proto_tree_add_item's i.s.o. proto_tree_add_text
-I am sorry but I did not understand the meaning of i.s.o, also is
there any problem in using proto_tree_add_text?
-->Using symbols like MIHF_ID, i.s.o. 52, make the source more readable
-I did not understand the meaning of this suggestion.
-->Header fields don't need colons at the end of the labels
-removed the unnecessary colons
-->dissector_add is deprecated for dissector_add_uint in this case
-changed the API call accordingly.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
