https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531
--- Comment #15 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-10-24 18:04:49 PDT ---
(In reply to comment #14)
> Created an attachment (id=7297)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7297) [details]
> added better error checking via tvb_offset_exists() calls where appropriate
>
> As per review suggestions, I've added more checking to make sure that the
> dissector doesn't run off the end of a tvb by making calls to
> tvb_offset_exists() where appropriate.
Hmm, I don't know about that. Typically it's better to let the dissector read
off the end of the TVB and throw an exception (indicating a malformed packet if
it reads past the reported end of the TVB or "packet truncated during
capturing" if it reads past the end of what was captured--e.g., if a snaplen
was used while capturing). Why does that need to be done in this dissector?
On an unrelated note: the asn1/c1222/Makefile.* changes don't reflect the
current trunk's way of doing things (that changed recently). That needs to be
changed (by either you or the committer before checkin).
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
