https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6153
--- Comment #19 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-10-19 07:08:22 PDT ---
Comment 10
>It should not be a heuristic dissector, the GTP dissection should be made
>by packet-gtp.c use the dissector table for CDR:s in packet-gtp.c or is there a
>compelling reason not to?
Still not addressed.
At a glance a lot of unused structures and variables etc examples(there are
more)
csg_ha_kut_svc_obsolete_t
struct csg_ha_ftp_t
hf_csg_ha_kut_flags
etc
Can't builtin functions be used insted of
csg_bytes_to_string() or proto_tree_add_item() with a hf type of FT_STRING?
csg_add_time() FT..TIME ?
csg_add_string_tlv() replace and use proto_tree_add_item() with hf of string
type?
csg_bcd_to_int() use tvb_bcd_dig_to_ep_str() ?
csg_fill_value() dubious, hidden fields are normaly not encouraged as a user
wouldn't know how to filter for it.
proto_tree_add_item() the last argument(FALSE) should be ENC_BIG_ENDIAN in
newly written code.
The way stuff is put in to the tree in dissect_csg_gtp_ies () does not look
right but as this is dealing with GTP it should all be removed and the GTP
dissector used as per the first comment.
Regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
