https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6324
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #7 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-10-17 18:59:46 PDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=7169)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7169) [details]
[details]
> > support for bgp mcast-vpn nlri
> >
> > Hi Alexis,
> >
> > Find attached a new patch. I made changes based on your remarks.
> >
> > However for item 4 I'm not sure what to do because the source address can be
> > ipv4 or ipv6. Should I use two header fields in this case:
> > hf_bgp_mcast_vpn_nlri_source_addr_ipv4 &
> > hf_bgp_mcast_vpn_nlri_source_addr_ipv6?
> >
> > thanks,
> > Thomas
>
> Hi Thomas,
> Yes, you should use 2 Header fields
Well, several more really: two for the source address, two for the router
address, etc.
Doing that would probably also allow you to avoid using proto_item_set_text()
in decode_mcast_vpn_nlri() (assuming you set up the hf's correctly).
One more comment: the call to tvb_length_remaining() should probably be
tvb_reported_length_remaining().
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
