https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6155
Tyson Key <tyson.key@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7246| |review_for_checkin?
Flag| |
--- Comment #5 from Tyson Key <tyson.key@xxxxxxxxx> 2011-10-15 03:52:08 PDT ---
Created an attachment (id=7246)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7246)
Version of the patch that introduces macros, and makes endianness explicit for
FT_UINT8s
I've replaced the direct references to Message Type magic numbers with macros,
cleaned up some misleading/typo'd comments, and demarcated all of the single
byte fields as being Big Endian/network byte order. Whether or not those
modifications yield nonsense results, or otherwise fail to compile is another
matter...
The specification states the following, regarding endianness:
"Fields that are larger than a byte are stored in little endian. Little endian
is a method of
storing data that places the least significant byte of multiple-byte values at
lower storage
addresses. For example, a 16-bit integer stored in little endian format places
the least
significant byte at the lower address and the most significant byte at the next
address".
I haven't investigated the columns or blurbs-related issues yet, though.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
