Wireshark-bugs: [Wireshark-bugs] [Bug 6400] New: PATCH - Address Coverty issues CID 1204, CID 12
Date: Wed, 28 Sep 2011 01:59:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6400

           Summary: PATCH - Address Coverty issues CID 1204, CID 1215, CID
                    1224, CID 1246, CID 1247
           Product: Wireshark
           Version: 1.7.x (Experimental)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Created an attachment (id=7103)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7103)
Address Coverty issues CID 1204, CID 1215, CID 1224, CID 1246, CID 1247

Build Information:
TShark 1.7.0 (SVN Rev 39174 from /trunk)

Copyright 1998-2011 Gerald Combs <[email protected]> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GLib 2.30.0, with libpcap 1.1.1, with libz 1.2.3.4, with
POSIX capabilities (Linux), with threads support, with SMI 0.4.8, with c-ares
1.7.4, with Lua 5.1, without Python, with GnuTLS 2.10.5, with Gcrypt 1.5.0,
with
MIT Kerberos, with GeoIP.

Running on Linux 3.0.0-12-generic, with locale de_AT.UTF-8, with libpcap
version
1.1.1, with libz 1.2.3.4.

Built using gcc 4.6.1.

--
The following issues have been addressed with this patch

CID 1204 - Parentheses are set correctly now, and the check works properly
CID 1215 - check against NULL has been included
CID 1224 - * has been removed from sizeof

CID 1246/1247 - The check has been removed. This was an artefact from an
earlier version of the dissector, and is not needed anymore.

The usual test have been performed like fuzztesting and randpkt.

regards,
Roland

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.