Wireshark-bugs: [Wireshark-bugs] [Bug 5784] New dissector for GSM A-bis OML
Date: Sun, 18 Sep 2011 10:54:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5784

--- Comment #3 from [email protected] 2011-09-18 10:54:04 PDT ---
Hi Jeff,

I have attached a new patch that applies to wireshark svn repository at
revision 36142. Regarding your questions:

(In reply to comment #1)
> A few comments based on a cursory review:
> 
> 1) we'll need a sample capture for testing & (especially) fuzz testing

Please, find it here:
http://openbsc.osmocom.org/trac/attachment/wiki/nanoBTS/ipaccess-startup-mo_to_mo_call-proxy.pcap

> 2) has this been fuzz tested?  There a are a couple unterminated value_strings
> which will lead to cores.

Yes, this new patch has been fuzz-tested with the aforementioned pcap file,
I've been using the fuzz-test.sh available under tools/, it's been running
during 4000 passes successfully.

BTW, I fixed the unterminated value_strings issue.

> 3) I'd suggest running checkApis and checkhf on this.  For example, I noticed a
> couple of hf_ entries with blurbs which matched the description.

I've run checkApis and checkhf, now these scripts reports no problems at all.

> 4) It looks like the contents of the header file can/should be moved into the
> .c file.

I've moved the content of the .h file to the .c file.

> 5) Looks like there may be a couple unneeded #includes (stdio, for example).

I have removed the #include stdio.

I spent some time reviewing the patch and looking at README.Developer, as well
as looking at the API definitions under epan/ to make sure we were not abusing
any.

Please, let me know if you find any other issue, we'll be happy if this is
finally merged into mainstream.

Thank you!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.