Wireshark-bugs: [Wireshark-bugs] [Bug 5929] New protocol dissector for "CIP Motion"
Date: Fri, 16 Sep 2011 07:56:53 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5929

--- Comment #12 from Bill Meier <[email protected]> 2011-09-16 10:56:52 EDT ---
(In reply to comment #11)
> 
> 
> Wasn't sure if "public" variable or essentially recreating the value string was
> the way to go (and have that "common" code (i.e. large macro) in packet-cip.h).
>  In all likelihood they would remain the same.
> 

If a (large) value_string array is needed in more than one dissector source
file just have an static instance of the value_string array in one .c file and
then define a public value_string_ext pointer which is  referenced as needed.

See packet-bthci_cmd.c (& packet-hci_h4.h) for an example.

> 
> 
> I thought this was added at checkin time (automatically through SVN), and since
> the dissector is new, wouldn't that fall on the developer doing checkin?

It's not automatically added and should be part of the patch.

Search for $Id$ in doc/README.developer

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.