Wireshark-bugs: [Wireshark-bugs] [Bug 6343] PostgreSQL Startup message not properly supported by
Date: Thu, 15 Sep 2011 15:22:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6343

--- Comment #2 from Bill Meier <[email protected]> 2011-09-15 18:22:05 EDT ---
The display of the new field pgsql.val.count (aka Data count) is another
display of the bytes displayed by the existing text field "Columns". (The two
lines display the same two bytes from the frame).

+        proto_tree_add_item(tree, hf_val_count, tvb, n, 2, FALSE);
         ti = proto_tree_add_text(tree, tvb, n, 2, "Columns: %d", i);


    Data count: 1
    Columns: 1
        Column name: default_transaction_isolation
            Table OID: 0
---------

It seems to me that these bytes should only be displayed once: as a field;
i.e., remove the proto_tree_add_text()).

What do you think would be the right name for this field ?


P.S. the patch as supplied is "invalid".  At the end it had:

@@ -838,6 +846,7 @@
     proto_register_field_array(proto_pgsql, hf, array_length(hf));
     proto_register_subtree_array(ett, array_length(ett));

     mod_pgsql = prefs_register_protocol(proto_pgsql, proto_reg_handoff_pgsql);
     prefs_register_uint_preference(
         mod_pgsql, "tcp.port", "PGSQL TCP port", "Set the port for PGSQL "


I assumed that this was not relevant and removed it from the patch.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.