Wireshark-bugs: [Wireshark-bugs] [Bug 5680] SLL encapsuled 802.1Q VLAN is not dissected
Date: Wed, 14 Sep 2011 13:14:54 -0700 (PDT)

--- Comment #8 from Jaap Keuter <[email protected]> 2011-09-14 22:14:54 CEST ---
(In reply to comment #7)
> (In reply to comment #2)
> > The problem now is that the SLL dissector was passing protocol type 0x8100
> > (802.1q tag) to the ethertype() function so that it would call the 802.1q
> > "VLAN" dissector.  I integrated the 802.1q dissector into the Ethernet
> > dissector because I didn't think a non-Ethernet protocol would store an
> > Ethernet-like 802.1q tag.  It may be best to write the 802.1q support into the
> > SLL dissector -- but are the others that do this too?
> I thought you integrated the 802.1q dissector into the Ethernet dissector at
> the recommendation of Jaap as per comment 3 of bug2254?

Hold on here, that wasn't a recommendation. That was an observation. I never
subscribed to the idea of integrating the vlan dissector into the Ethernet
dissector. That's why I never picked up the work.
If someone else did like the idea, and did the research and the work, that's
fine. Not pointing fingers, but now we see the poor basis of the idea, and the
limits of the preparations done.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.