Wireshark-bugs: [Wireshark-bugs] [Bug 6322] RTP Stream Analysis does not work for TURN-encapsula
Date: Thu, 8 Sep 2011 11:00:20 -0700 (PDT)

--- Comment #6 from Bill Meier <[email protected]> 2011-09-08 14:00:18 EDT ---
(In reply to comment #4)

> That said I haven't looked too deeply into the patch I just wanted to convey
> the information to Bill to save him some effort.

Thanks, Anders  (I'm not familiar with STUN, RTP, etc) so the help is

> Hi,
> If there is a way to have the tap to call dissect_stun_message() with a non
> NULL tree the patch would not be needed, I may be mixing this up with the VoIP
> call functionality.

As noted by Guy in Comment #5, the patch to packet-stun to always call the
subdissector should be done. I've tested it and it works as advertised.

> I'm not sure the RTP changes are OK for non STUN traffic.

I've looked at this a bit and note the following:

- dissect_rtp_heur() is registered only for the  UDP and STUN dissectors.
- dissect_stun_heur() is registered for TCP, UDP and STUN.
- So: It appears that RTP could be carried over UDP STUN. 
  Can/Will this happen ? 
  If so, will the STUN UDP port always be even so that the test for an even UDP
  port in dissect_rtp_heuristic succeeds ?
  (Or do I misunderstand how this works ?)

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.