Wireshark-bugs: [Wireshark-bugs] [Bug 6322] RTP Stream Analysis does not work for TURN-encapsula
Date: Thu, 8 Sep 2011 08:41:45 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6322

Ken Cox <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6954|review_for_checkin?         |
               Flag|                            |
   Attachment #6954|0                           |1
        is obsolete|                            |

--- Comment #3 from Ken Cox <[email protected]> 2011-09-08 08:41:44 PDT ---
Created an attachment (id=6958)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6958)
proposed patch, take 2

Oops, thanks for the catch.  I did not mean to include my local changes to
tap-rtp-common.c.  Those changes contain assumptions of nonstandard payload
types, but they enable me to analyze RTP streams in the absence of the SIP
negotiation.

However, I don't understand your comment about the packet-rtp.c and
packet-stun.c changes.  The change to packet-stun.c is required because the TAP
calls dissect_stun_message() with a NULL tree.  Without the patch, during TAP,
dissect_stun_message() would return immediately without calling
dissector_try_heuristic() and the encapsulated RTP would not be recognized. 
The change the packet-rtp.c is required because when RTP is tunneled though
TURN with a TCP transport, the local port number may not be even numbered.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.