Wireshark-bugs: [Wireshark-bugs] [Bug 6318] New: VoIP Calls->Graph TCS and OLC display corruptio
Date: Thu, 8 Sep 2011 04:50:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6318

           Summary: VoIP Calls->Graph TCS and OLC display corruption
           Product: Wireshark
           Version: SVN
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Build Information:
Version 1.2.7 (This is also present svn @ r38933)

Copyright 1998-2010 Gerald Combs <[email protected]> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.20.0, with GLib 2.24.0, with libpcap 1.0.0, with libz
1.2.3.3, with POSIX capabilities (Linux), with libpcre 7.8, with SMI 0.4.8,
with
c-ares 1.7.0, with Lua 5.1, with GnuTLS 2.8.5, with Gcrypt 1.4.4, with MIT
Kerberos, with GeoIP, with PortAudio V19-devel (built Feb 18 2010 22:31:30),
without AirPcap.

Running on Linux 2.6.32-33-generic-pae, with libpcap version 1.0.0, GnuTLS
2.8.5, Gcrypt 1.4.4.

Built using gcc 4.4.3.

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
When using Wireshark to graph a VoIP call (Telephony->VoIP Calls...->Select
All->Graph or Flow) the H245 TCS display is corrupt and the OLC display is not
what is intended.

The TCS:

Rather than display "TCS" it displays "TCS(TCS(TCS(TCS(TCS(TCS(TCS)" - see the
attached image at position 2.541 on the timeline for an example.

The OLC:

Rather than show "OLC (genericVideoCapability)" just "(genericVideoCapability)"
is shown. See position 5.220 on the timeline for an example.

Causes: Both these issues seem to be caused by using the same buffer as both
the source and destination in calls to g_snprintf.

Proposed fixes (patch to be attached soon!)

The TCS:

The code intention seems to be to display "TCS" and the most recent codec
dissected in brackets after, eg "TCS (genericVideoCapability)". IMO displaying
the most recent codec dissected, which will be the last codec in the TCS, is
not of any use. This should just display "TCS"

The OLC:

The code intention here is to display "OLC (genericVideoCapability)" - this is
very useful when looking at the Graph/Flow output. This should be fixed to work
as so IMO.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.