Wireshark-bugs: [Wireshark-bugs] [Bug 6207] Add the ability to save filters from the Filter Tool
Date: Wed, 7 Sep 2011 15:17:52 -0700 (PDT)

Edwin Groothuis <[email protected]> changed:

           What    |Removed                     |Added
   Attachment #6911|0                           |1
        is obsolete|                            |

--- Comment #24 from Edwin Groothuis <[email protected]> 2011-09-07 15:17:49 PDT ---
Created an attachment (id=6942)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6942)
After comments 23

> - The "Deleted" column should be replaced with a "Delete" button, as it does
> not make much sense (to me) to have this in a column.

Changed now.

> - The text above the table is incorrect.


> - The tooltip tells me to "Click on a title to change its name", but there is
> no titles here.


> - The tooltip tells me to "Drag an item to change its order".  This does not
> work.

it does for me:
- When clicking to drag on a row which is highlighted, it will go into edit
mode for the label or expression.
- When clicking to drag on a row which is not highlighted, it will float and
move around.

> - The size of the display filter box should not be resized in this patch.
>  (I'm thinking about adding a handle between the filter and the buttons and
>  save the size in the recent file)

Is that not GTK driven?

> - Trying to save a filter with a existing name does not give the user any
> warning.

Limitation removed.

> - All fields accepting a display filter does do syntax checking and adds a
> color to the background.

That would be nice but close to impossible for me. For people with more GTK-fu
probably doable. The issue is that the editing part is done by the listbox over
which I don't have control. Copying the contents to an edit field outside the
listbox would be possible but I don't know how to synchronize the two fields

> It should be easy to remove a button directly from the toolbar, and maybe be
> able to edit the title and display filter without having to open the
> preferences.  We have this functionality for columns, where you can
> left-click the column header to change settings, show/hide and remove columns.

This would add a menu to a button, something which I don't know how to do.


Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.