Wireshark-bugs: [Wireshark-bugs] [Bug 6017] No Cisco FabricPath protocol dissector included
Date: Wed, 7 Sep 2011 10:16:59 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6017

--- Comment #9 from Leonard Tracy <[email protected]> 2011-09-07 10:16:58 PDT ---

The problem I had with registering the ethertype was that I found the eth
dissector consuming the outer source and destination address and passing only
the FabricPath tag.  I wanted to parse the outer address differently than the
eth dissector does.  The only way I found to get the frame before the eth
dissector was to use a heuristic dissector.

I asked for another way to do this, but I got no reply.  For lack of a better
solution, I simply set this protocol to default to off as suggested by another
reviewer.

(In reply to comment #8)
> Hi,
> The ethertype #8903 is registerd with
> IEEE(http://standards.ieee.org/develop/regauth/ethertype/eth.txt) as "DCE"
> wikipedia has this as Data Center Ethernet. I have submitted a patch
> "labeling" it it as such, ETHERTYPE_DCE.
> 
> As your dissector just checks the ethertype I see no reason to regester it as
> a heuristic, register it for the ethertype instead. Don't use tvb_get_ptr()
> use the tvb accessor functions instead.
> 
> Regards
> Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.