Wireshark-bugs: [Wireshark-bugs] [Bug 5680] SLL encapsuled 802.1Q VLAN is not dissected
Date: Fri, 2 Sep 2011 12:46:54 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5680

--- Comment #5 from Sandeep Dahiya <[email protected]> 2011-09-02 12:46:54 PDT ---
(In reply to comment #3)
> ... Taking out a protocol dissector,
> then requesting its users to implement it themselves. I don't know about
> others, but stuff like is bound to come up, so this should be handled through
> an entry point, now in the Ethernet dissector.

I agree with Jaap. The Ethernet dissector should ideally handle the 802.1q
bytes. I am currently working on another dissector (apart from bug #6305) for
Cisco VNTAG dissector. I came across the same problem there too. Having the
code to handle the same header, spread across individual dissectors is likely
to create more bugs later on. Not to mention the overhead of updating it
multiple places if required later on.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.