ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 6172] Crash in "Follow TCP Stream"

Date: Tue, 2 Aug 2011 09:04:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6172

--- Comment #9 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2011-08-02 10:04:06 MDT ---
More notes for if (more likely when) I get interrupted and forget where I'm
at... :)

The information for these tags is in pinfo->data_src, which is a GSList (GLIb
singly linked list).  There are two instances of add_new_data_source() in
epan/dissectors/packet-tcp.c by the name "Reassembled TCP" so I put a number on
each and found out that it's the one on line 1783 in desegment_tcp() being
used.

I noticed that free_data_sources() in epan/packet.c does a g_slist_free of
pinfo->data_src as a whole and then sets the pointer to be NULL.  But it
doesn't free the contents of the list elements, just the list itself.  The
add_new_data_source() function appends an entry to the GSList of type
"data_source *src" which is ep_alloc() -- perhaps this is related to the
problem, that it's not a se_alloc?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.