https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6163
--- Comment #2 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2011-07-25 08:19:33 PDT ---
Hi,
It's quite anoying with this repeated text block
"+/*
+This extension to Wireshark was written by Torsten Loebner
(loebnert@xxxxxxxxxxxxxx)
+in the context of a graduation project with the research organization TNO in
Delft,
+Netherland. The extension is based on the RTCP XR block specified in
+ETSI TS 182 063 v3.5.2 Annex W
(http://www.etsi.org/deliver/etsi_ts/183000_183099/183063/),
+which was registered by IANA as RTCP XR Block Type 12
+(http://www.iana.org/assignments/rtcp-xr-block-types/rtcp-xr-block-types.xml).
+*/"
Wouldn't it be more apropriate to do someting like
* Copyright 2010, Matteo Valdina <zanfire@xxxxxxxxx>
+ * Dissection of RTCP XR block specified in
+ETSI TS 182 063 v3.5.2 Annex W added by ... as part of ...
etc
C++ type coments // is prohibited.
I'd prefere this type of lines
+ proto_tree_add_item(content_tree, hf_rtcp_xr_idms_spst, tvb, offset,
1, FALSE); offset+=3;
to be
+ proto_tree_add_item(content_tree, hf_rtcp_xr_idms_spst, tvb, offset,
1, FALSE);
+ offset+=3;
Couldn't:
+ buff=ntp_fmt_ts(tvb_get_ptr( tvb, offset-8, 8 ));
+ item = proto_tree_add_string_format( content_tree, hf_rtcp_ntp, tvb,
offset-8, 8, buff, "NTP timestamp of reception: %s", buff );
Be replaced by something like:
proto_tree_add_item(PoC1_tree, hf_rtcp_app_poc1_request_ts,
tvb, offset, 8,
ENC_TIME_NTP|ENC_BIG_ENDIAN);
Why should it be marked as a generated item?
Best regards
Anders
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
