Wireshark-bugs: [Wireshark-bugs] [Bug 6060] Universal Alcatel Protocol
Date: Mon, 27 Jun 2011 02:42:32 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6060

Alexis La Goutte <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #3 from Alexis La Goutte <[email protected]> 2011-06-27 02:42:30 PDT ---
a Quick Review

Please add diff of your dissector (see
http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcDiffWhat
)

Checkhf and checkAPI is not happy :
 ./tools/checkhf.pl epan/dissector/packet-ua.cERROR: NO ARRAY:
epan/dissector/packet-ua.c, hf_ua_direc
./tools/checkAPIs.pl epan/dissector/packet-ua.cError: Found non-ASCII
characters on line 273 of epan/dissector/packet-ua.c
[..]
Warning: epan/dissector/packet-ua.c does not have an SVN Id tag.
Error: the blurb for field "NOE item" ("ua.noe") matches the field name in
epan/dissector/packet-ua.c
[...]
Error: Found C++ style comments in epan/dissector/packet-ua.c

The comment need to be in English

Check also white-space

proto_register/proto_reg_handoff need to be in end of file

The code is fuzzed ?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.