Wireshark-bugs: [Wireshark-bugs] [Bug 6000] [PATCH] Bitcoin dissector
Date: Thu, 23 Jun 2011 14:02:44 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6000

--- Comment #5 from Bill Meier <[email protected]> 2011-06-23 17:02:43 EDT ---
1. The dissector doesn't compile on my Windows 32 bit system (MSVC 2008):

packet-bitcoin.c
packet-bitcoin.c(570) : error C2220: warning treated as error - no 'object'
file generated
packet-bitcoin.c(570) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(586) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(587) : warning C4244: '+=' : conversion from 'guint64' to
'guint32', possible loss of data
packet-bitcoin.c(611) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(619) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(620) : warning C4244: '+=' : conversion from 'guint64' to
'guint32', possible loss of data

2. get_varint():

   I think tvb_length_remaining should probably be
   tvb_reported_length_remaining()

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.