Wireshark-bugs: [Wireshark-bugs] [Bug 5881] Media Independent handover (MIH) protocol dissector
Date: Wed, 22 Jun 2011 05:40:22 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881

--- Comment #8 from Ankith <[email protected]> 2011-06-22 05:40:21 PDT ---
Thank you for reviewing the plugin...
   the following has been done...

1. The dissector has been fuzz tested as described in this link..
           http://wiki.wireshark.org/FuzzTesting. 
   The script never stops..   $./tools/fuzz-tes.sh ~/Desktop/mih_capture
 the output is 
Starting pass 1:
    /home/ankit/Desktop/mih_capture:  OK
Starting pass 2:
    /home/ankit/Desktop/mih_capture:  OK

and continues till it is not forced stopped...

2.  The comment 
   /*assumed for now but has to be changed accordingly*/

   has been removed in the updated version.

3. len_of_len is assigned but never used.

   This variable is removed in the updated version..

4.  Frame #1: 
      - TLV 3: Unknown TLV type

this was put intentionally to give an idea that these types are for
experimental purpose, as stated in the IEEE 802.21 standard.

5. All TLV "values" are being displayed as FT_STRING.
   This is appropriate only if the values are really always strings (which
   appears not to be the case).
   If there's not to be TLV type-dependent value dissection, then I think
   FT_BYTES should be used.

   The datatype of "values" in TLV depends on the type of the TLV, thus a
generic datatype is taken (string). I will check the usage of FT_BYTES and
change the patch accordingly.

6. The standard does not specify the maximum number of TLVs that can be put in
a packet. Thus, i was a little confused in defining them. I will go through
ett_array and make the corresponding changes to the patches...

Regards
Ankith

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.