Wireshark-bugs: [Wireshark-bugs] [Bug 5972] Wireshark Plugin for CSG2 Interfaces
Date: Thu, 9 Jun 2011 23:02:20 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5972

--- Comment #16 from Anders Broman <[email protected]> 2011-06-09 23:02:17 PDT ---
Hi,
Please include the header file into the .c file as it's not used outside of the
dissector.

CheckApi (nmake -f makefile.nmake checkapi)shows:

Warning: packet-csg.c does not have an SVN Id tag.
Error: Found prohibited APIs in packet-csg.c: g_sprintf,strcpy,strcat
Error: Found deprecated APIs in packet-csg.c: dissector_add

This routine is not used, remove?
static char *csg_bytes_to_string(tvbuff_t *tvb, int offset, int length)

Prohibited API
-                 g_sprintf(seq, " %x", tvb_get_ntohs(tvb, offset + 3 + i*2));
+                 g_snprintf(seq, 10, " %x", tvb_get_ntohs(tvb, offset + 3 +
i*2));

Starting WS:

07:49:52          Err  Field 'Session Correlator' (csg-ft.sess.corr) is an
FT_BY
TES but is being displayed as BASE_HEX instead of BASE_NONE
There are more similar faults.

/Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.