Wireshark-bugs: [Wireshark-bugs] [Bug 5990] SERCOS III built-in dissector (from plugin)
Date: Mon, 6 Jun 2011 08:16:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5990

Michael Mann <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6450|review_for_checkin?         |
               Flag|                            |
   Attachment #6450|0                           |1
        is obsolete|                            |
   Attachment #6469|                            |review_for_checkin?
               Flag|                            |

--- Comment #5 from Michael Mann <[email protected]> 2011-06-06 08:16:10 PDT ---
Created an attachment (id=6469)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6469)
SERCOS III dissector as single plugin file

I made 2 changes when merging the source into a single file:
1. Changed filtername to "siii" to match display filter fields (was quicker
than changing all display filter fields to "sercosiii"
2. Converted the "ett_siii arrays" to a single value.   Each subtree doesn't
need its own ett_ value.

Most of my testing was with the source in the epan/dissectors directory (plugin
removed).  I noticed in fuzztesting the source that fuzz-test.sh threw up a
warning about the open-safety protocol needing the sercos plugin.  Didn't know
if that was hardcoded to address recent issues, or it should be removed anyway
because going forward the plugin won't exist.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.