ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 5990] SERCOS III built-in dissector (from plugin)

Date: Sat, 4 Jun 2011 08:06:33 -0700 (PDT)

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
                 CC|                            |rknall@xxxxxxxxx

--- Comment #2 from Roland Knall <rknall@xxxxxxxxx> 2011-06-04 08:06:32 PDT ---
(In reply to comment #1)
> Created an attachment (id=6450)
 --> ( [details]
> SERCOS III dissector source in epan/dissector directory
> This source shouldn't need to be added as a patch, it should just be moved from
> the plugins/sercosiii directory to the epan/dissectors directory.

I do have some suggestions though. 

1. Why still keep packet-sercosiii.h? The only definitions in there, which
should be globally available throughout the dissector code are:

#define MAX_SERCOS_DEVICES (512)


2. In total the whole dissector code has 1973 lines. There are quite a few
other dissectors with more lines of codes.

I would suggest, combining the files into one, and adding the dissector as a
whole. Right now, there are 1315 files in the dissectors sub directory.
Unnecessarily adding 9 more, where 1 should suffice, seems rather pointless.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.