Wireshark-bugs: [Wireshark-bugs] [Bug 5972] Wireshark Plugin for CSG2 Interfaces
Date: Thu, 2 Jun 2011 13:03:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5972

--- Comment #12 from Anders Broman <[email protected]> 2011-06-02 13:03:46 PDT ---
Hi,
-You should build this against trunk.
Check the base of FT_IPv4, FT_IPv6 and FT_ABSOLUTE_TIME.

-In the hf declarations like :
    { &hf_ha_kut_qsip, { "Kut Quota Server IP", "csg-ft.kut.qsip", FT_IPv4,
BASE_NONE,
                         NULL, 0, "", HFILL }},

An empty blurb "" should be replaced by NULL.
I'd prefere the format:
    { &hf_ha_kut_qsip, 
        { "Kut Quota Server IP", "csg-ft.kut.qsip", 
        FT_IPv4, BASE_NONE, NULL, 0, 
        NULL, HFILL }
   },
- At least all fields should have the same format.
- Prefix all hf variables with hf_cfg...
- Instead of duplicating GTP code change the GTP dissector to accept a port
range. Make a dissector table for record types and have your dissector register
for record format 49(make that a preference).

It would be nice with more traces exercising more code in the dissector.
Regards
Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.