Wireshark-bugs: [Wireshark-bugs] [Bug 5622] Incomplete support of OSI protocol dissectors for CL
Date: Fri, 28 Jan 2011 08:42:37 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5622

--- Comment #6 from Bill Meier <[email protected]> 2011-01-28 11:42:33 EST ---
Ok:

I've not yet examined the patch in depth but I do notice the following:


1.  IP_PROTO_ISOIP is registered twice:

packet-osi.c

+    dissector_add_uint("ip.proto", IP_PROTO_ISOIP, osi_handle); \
              /*  ISO-TP4 ISO Transport Protocol Class 4 [RFC905,RC77] */  

packet-clnp.c

+    dissector_add_uint("ip.proto", IP_PROTO_ISOIP, clnp_handle); \
              /* OSI, ATN over IPv4 RFC 791 */


   This doesn't work. The "last" registration will overwrite earlier
   registrations. Since the registrations are more or less done in
   alpha order (see register.c), this means that the registration
   in packet-osi.c is the one that ends up as effective.

   Exactly what is carried over IP for IP_PROTO_ISOIP ?

2. Applying the patch but just with the packet-osi.c ip.proto registration
   and then opening the capture file 2011-01-27-dump-atn-over-ip.pcap,
   I see that the file appears to contain only ES-Hello and IS-Hello messages.
   Is this as expected ?

   If I apply the patch but just with the packet-clnp.c ip.proto registration
   I get malformed clnp messages.


3. The patch to packet-osi.h contains only whitespace changes: two
   additional blank lines. is something missing ? if not, please don't
   include same.

3. A number of the lines in the patch have trailing blanks. It is much
   preferred that lines not have trailing blanks.

4. Can you provide a URL to specifications for:

    2) CLNP security label containing ATN "Traffic Type" and "Security
       Classification"
    3) different TDPU sizes (due to "32-bit ATN extended Checksum")  
    4) check of OSI(16-bit) and ATN extended(16-bit,32-bit) checksums

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.