Wireshark-bugs: [Wireshark-bugs] [Bug 5535] Remove batadv dissector
Date: Tue, 4 Jan 2011 13:24:51 -0800 (PST)

--- Comment #4 from Sven Eckelmann <[email protected]> 2011-01-04 13:24:50 PST ---
(In reply to comment #3)
> (In reply to comment #0)
> > The batadv dissector wasn't really welcome by the wireshark developers due to
> > the fact that batman-adv is a always changing protocol. This created a lot of
> > duplicated code inside the dissector. This patch removes the dissector due to
> > the massive amount of changes waiting to be added to it which would create even
> > more duplicated code.
> Really?  I wasn't aware of that. Looks like all the batadv bugs are closed and
> the patches were checked in (well, I'm going by what I can find in my 'bugs'
> emails).  Admittedly we may be somewhat slow to check them in...

Sry, there seems to be a misunderstanding. The changes are for batman-adv and
those would make it necessary to add more code to the batman-adv dissector.

> I also don't quite see why this is leading to duplicated code. Do you mean
> duplicated between Wireshark and somewhere else or...?

Duplicated code inside the dissector. See bug #4920

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.