Wireshark-bugs: [Wireshark-bugs] [Bug 4334] VNC Hextile encoding is incomplete
Date: Wed, 15 Dec 2010 12:03:15 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4334

--- Comment #5 from Yaniv Kaul <[email protected]> 2010-12-15 12:03:15 PST ---
(In reply to comment #4)
> Created an attachment (id=5620)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5620) [details]
> patch (not for commit!) for packet-vnc.c - with basic desegmentation support

Attached patch is a WORK IN PROGRESS, not for commit, that:
1. Adds extended desktop size pseduo-encoding (provided via another BZ to
existing VNC dissector)
2. Moves bytes per pixel from global variable (which is very wrong) to per
conversation (will try to submit as an independent patch to existing VNC
dissector - can't commit to that)
3. Fixes Hextile decoding, which is completely wrong (plan to submit via
another BZ to existing VNC dissector)

but most of all, it provides:
4. Basic infrastructure for VNC desegmented dissection, done right.
It's horribly done, by providing a walk_message_x() function for every message,
that essentially decodes most of the message in order to get the complete PDU
for it. 
I'm quite confident I will not be able to pursue this, so I'm attaching it here
in the hope that someone be able to pick it up.

It's also sprinkled with debug messages. Well, work in progress...

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.