Wireshark-bugs: [Wireshark-bugs] [Bug 5466] Improve dissection of bit-oriented fields, text fiel
Date: Fri, 10 Dec 2010 07:48:07 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5466

--- Comment #21 from Chris Maynard <[email protected]> 2010-12-10 07:48:03 PST ---
(In reply to comment #20)
> Yeah, these are just errors. I will fix them.

Hmm, I changed them, but then the display really didn't make sense as it showed
things like, for example, for scsi.cdb.control.obs1,
    ".... ..0. = Obsolete: False" 
So I changed them back so it would now just show this again:
    ".... ..0. = Obsolete: 0x00" 

> I unfortunately work both on Linux kernel code, where tabs are to be used and,
> for the moment, Wireshark (after not having worked on Wireshark for years). I
> will try to get into the habit of setting my .vimrc to convert tabs to 8
> spaces.

I wish it were that simple.  Wireshark doesn't have a coding standard per se,
when it comes to tabs vs. spaces or even the number of spaces per tab.  As
section 1.1.5 of README.developer points out:  "When creating a new file, you
are free to choose an indentation logic."

So what you'll find is that the spacing differs all over the place,
unfortunately even within a single file, like packet-scsi.c, where it mostly
uses 4-space indentation, but parts of it have been spaced differently and
there were a limited number of lines with tabs as well.  Anyway, it's not a
huge deal so I don't want to seem like I'm focusing on it, but it's something
to be aware of I guess.  Since there really wasn't that many tabs in
packet-scsi.c, I removed them all.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.