Wireshark-bugs: [Wireshark-bugs] [Bug 5476] ICMPv6 Enhancements : make ICMP option filterable (P
Date: Wed, 8 Dec 2010 23:53:15 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5476

--- Comment #3 from Alexis La Goutte <[email protected]> 2010-12-08 23:53:10 PST ---
(In reply to comment #2)
> This patch reverts http://anonsvn.wireshark.org/viewvc?view=rev&revision=35060> 
Yes and no, this allow to display the prefix in IPv6 format (with filter)
(but i check the fuzzed pcap capture and no crash)
Also, the copy for section RFC is needed ?

> -/*  1 */    { ND_OPT_SOURCE_LINKADDR,           "Source link-layer address" },
> I'm not sure removing the number is a good idea, personally I don't like
> using symbols in this type of value_string tables as it's harder to check
> the list when going back to IANA:s tables(or any othe standards document),
> but that might just be me :-)
> Regards
> Anders

The list of #define is above of value_string
I also add a comment (with name and id) for case on the switch
-    case ND_OPT_SOURCE_LINKADDR:
+    case ND_OPT_SOURCE_LINKADDR: /* Source Link-layer Address (1) */

but if we must add, I add!

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.